Skip to content

Conversation

faysou
Copy link
Collaborator

@faysou faysou commented Mar 4, 2025

Pull Request

Refine mixed catalog client requests

  • Allow to extend a catalog after its last datetime or before its first date time
  • Automatic determination of append and prepend catalog write mode
  • Note: to avoid creating holes in the data, priviledge only using start date and not end date in data requests when updating the catalog as well. Update: I've added a condition enforcing not using both end and update_catalog_mode at the same time.

Type of change

  • New feature (non-breaking change which adds functionality)

How has this change been tested?

Existing tests passing, more tests needed, possibly after a merge. Found and fixed bugs to make existing tests work. Also the key logic is concentrated in _handle_date_range_request and is easy to understand.

@faysou faysou force-pushed the catalog_bounds branch 4 times, most recently from cb79ed1 to ff4cf96 Compare March 4, 2025 18:38
@cjdsellers cjdsellers merged commit 5edfb34 into develop Mar 4, 2025
12 checks passed
@cjdsellers cjdsellers deleted the catalog_bounds branch March 4, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants