Skip to content

Conversation

faysou
Copy link
Collaborator

@faysou faysou commented Aug 8, 2025

Pull Request

NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.

  • I have reviewed the CONTRIBUTING.md and followed the established practices

Summary

Related Issues/PRs

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Breaking change details (if applicable)

Documentation

  • Documentation changes follow the style guide (docs/developer_guide/docs.md)

Release notes

  • I added a concise entry to RELEASES.md that follows the existing conventions (when applicable)

Testing

Ensure new or changed logic is covered by tests.

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic

@faysou faysou force-pushed the refine_request_instrument branch from 3e91021 to 6dfccdd Compare August 8, 2025 16:01
@cjdsellers cjdsellers merged commit d577b6d into develop Aug 9, 2025
13 checks passed
@cjdsellers cjdsellers deleted the refine_request_instrument branch August 9, 2025 07:10
Bshara23 pushed a commit to Bshara23/nautilus_trader that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants