Refine subscribe_historical_bars in IB adapter #2870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faysou
force-pushed
the
ib-bar-fix
branch
3 times, most recently
from
49d780b to
444f1df
Compare
faysou
force-pushed
the
ib-bar-fix
branch
2 times, most recently
from
7904d34 to
8e42ad6
Compare
cjdsellers
reviewed
Aug 22, 2025
| Indicates whether revised bars should be handled or not. | ||
| historical : bool | None, optional | ||
| Indicates whether the bar data is historical. Defaults to False. | ||
| start: int, optional |
There was a problem hiding this comment.
I think if start is not a pd.Timestamp then we should always suffix the units, like start_ns. The choice to use nanos depends on the abstraction level, generally passing around a pd.Timestamp is a little nicer unless it's passing into Cython territory.
There was a problem hiding this comment.
Passing timestamp in messages can pose serialisation issues. I can refactor to rename start as starts_ns.
There was a problem hiding this comment.
Yes, that's a good example of when we'd want to use a nanoseconds integer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.
CONTRIBUTING.mdand followed the established practicesSummary
Related Issues/PRs
Type of change
Breaking change details (if applicable)
Documentation
docs/developer_guide/docs.md)Release notes
RELEASES.mdthat follows the existing conventions (when applicable)Testing
Ensure new or changed logic is covered by tests.