fix: allow configuring scrapeProtocols for ServiceMonitor#732
Merged
Conversation
DRF intermittently fails to negotiate content type while serving HTTP requests for metrics from Prometheus. Details of this bug are available in nautobot/nautobot#8026 As a workaround, this PR adds ability to explicitly configure scrapeProtocols which effectively avoids the problem.
Contributor
|
@skrobul Thank you for opening this PR. Overall, the PR looks good. Do you mind adding metrics:
serviceMonitor:
# -- ([]string) <PROVIDE SHORT DESCRIPTION>
scrapeProtocols: []After that, I think we are good to merge. |
Contributor
Author
|
@ubajze thanks for the review - added to values.yaml and updated helm-docs. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRF intermittently fails to negotiate content type while serving HTTP requests for metrics from Prometheus.
Details of this bug are available in nautobot/nautobot#8026
As a workaround, this PR adds ability to explicitly configure
scrapeProtocolswhich effectively avoids the problem of content negotiation and thus triggering the bug.