Skip to content

fix time scale interpretation#162

Merged
gwbres merged 16 commits intomainfrom
gnss-time
Sep 19, 2023
Merged

fix time scale interpretation#162
gwbres merged 16 commits intomainfrom
gnss-time

Conversation

@gwbres
Copy link
Copy Markdown
Collaborator

@gwbres gwbres commented Sep 8, 2023

This branch solves the following issue

Previous version of RINEX would identify most Epochs as UTC Epoch.
This is incorrect, as per RINEX specifications. Refer to the related issue for more information.

This branch proposes a fix that solves the Navigation and Observation Data cases which are the most complex.

To solve that, we use Epoch::from_str("YYYY-MM-DDTHH:MM:SS TS") which let us identify an Hifitime Epoch in almost any timescale.

This blocks any progress towards accurate positioning

Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
@gwbres gwbres added this to the v1.0.0 milestone Sep 8, 2023
@gwbres gwbres self-assigned this Sep 8, 2023
@gwbres gwbres linked an issue Sep 8, 2023 that may be closed by this pull request
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
@gwbres gwbres added enhancement New feature provided bug-fix Fix proposal labels Sep 18, 2023
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
@gwbres gwbres marked this pull request as ready for review September 19, 2023 07:56
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Comment thread rinex/src/epoch/mod.rs Outdated
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
@gwbres gwbres merged commit 929d302 into main Sep 19, 2023
@gwbres gwbres deleted the gnss-time branch September 19, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Fix proposal enhancement New feature provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decoded Epoch type often has wrong timescale

2 participants