Skip to content

Add warning to rename script #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2024
Merged

Add warning to rename script #34

merged 4 commits into from
Jun 20, 2024

Conversation

rocketnova
Copy link
Contributor

@rocketnova rocketnova commented Jun 19, 2024 •
edited
Loading

Ticket

  • N/A

Changes

What was added, updated, or removed in this PR.

  • Updates template-only-bin scripts

Context for reviewers

Background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.

In #29, I accidentally committed the branch name in the template-only-bin scripts. This PR reverts it back to main.

This PR also adds a warning to the rename script. See #29 (comment)

Testing

Provide testing instructions and evidence that the code works as expected. Include screenshots, GIF demos, shell commands or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

CleanShot 2024-06-18 at 17 36 43@2x

@rocketnova rocketnova requested review from a team, SammySteiner and ellery-nava June 19, 2024 00:39
@rocketnova rocketnova mentioned this pull request Jun 19, 2024
Merged
lorenyu
lorenyu approved these changes Jun 20, 2024
View reviewed changes
template-only-bin/rename-template-app Outdated

echo
echo "===> Review all changes carefully using 'git diff' before committing!"
echo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add newline at EOF

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the catch.

@rocketnova rocketnova merged commit 8c2e720 into main Jun 20, 2024
3 checks passed
@rocketnova rocketnova deleted the rocket/rename-warning branch June 20, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenyu lorenyu lorenyu approved these changes

@aligg aligg aligg approved these changes

@SammySteiner SammySteiner Awaiting requested review from SammySteiner

@ellery-nava ellery-nava Awaiting requested review from ellery-nava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rocketnova @lorenyu @aligg