Skip to content

Fail CI on lint check #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2024
Merged

Fail CI on lint check #46

merged 2 commits into from
Jun 28, 2024

Conversation

SammySteiner
Copy link
Contributor

Ticket

Changes

  • Update CI workflow to fail if offenses are detected by the linter.

Context for reviewers

This should fail the first check as there are offenses in the repo. Once I've confirmed this is working as expected, I'll correct them in another commit.

Testing

  • failed CI run since there are known lint errors
  • running linting locally shows no more errors (once that commit is added)

rocketnova
rocketnova approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@rocketnova rocketnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@SammySteiner SammySteiner merged commit 4f8e5f7 into main Jun 28, 2024
5 checks passed
@SammySteiner SammySteiner deleted the sammysteiner/44-ci-fail-on-lint branch June 28, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocketnova rocketnova rocketnova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate linting
2 participants
@SammySteiner @rocketnova