This repository was archived by the owner on Jun 2, 2021. It is now read-only.
Make VaultProvider use API version 1 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vault driver lib has a issue with vault resource pathing ref: BetterCloud/vault-java-driver#189 Forcing use of version 1, which is the version on the resources nada-kafka-conenct uses atm, seems to solve the issue.
|
Is the test setup working with this change? There was issues with getting Vault to work in the tests, presumably because the tests are not using engine v1? |
|
Yes, the default vault engine is version 2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vault driver lib has a issue with vault resource pathing ref:
BetterCloud/vault-java-driver#189
Forcing use of version 1, which is the version on the resources nada-kafka-conenct uses atm, seems to solve the issue.