Skip to content

Enhancements and fixes over hydra#15

Merged
timkpaine merged 14 commits intonbprint:mainfrom
Point72:tkp/rs+
Feb 21, 2026
Merged

Enhancements and fixes over hydra#15
timkpaine merged 14 commits intonbprint:mainfrom
Point72:tkp/rs+

Conversation

@timkpaine
Copy link
Member

No description provided.

- Add Rust/PyO3 library in src/ for core functionality
- Add pure Rust library in rust/ for testing
- Move tests/ to lerna/tests/ and fix imports
- Update pyproject.toml for maturin build
- Add Windows path compatibility fixes in Rust tests
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 85.58719% with 81 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lerna/_internal/instantiate/_instantiate2.py 38.66% 30 Missing and 16 partials ⚠️
lerna/core/override_parser/types.py 0.00% 15 Missing ⚠️
lerna/_internal/config_loader_impl.py 80.64% 3 Missing and 3 partials ⚠️
lerna/core/override_parser/overrides_parser.py 76.92% 3 Missing ⚠️
lerna/_internal/utils.py 60.00% 2 Missing ⚠️
lerna/main.py 0.00% 2 Missing ⚠️
lerna/test_utils/a_module.py 0.00% 2 Missing ⚠️
lerna/tests/__init__.py 75.00% 1 Missing and 1 partial ⚠️
lerna/_internal/core_plugins/basic_sweeper.py 75.00% 0 Missing and 1 partial ⚠️
lerna/core/default_element.py 96.29% 1 Missing ⚠️
... and 1 more
Files with missing lines Coverage Δ
.../core_plugins/importlib_resources_config_source.py 85.26% <100.00%> (+1.35%) ⬆️
lerna/_internal/defaults_list.py 75.90% <100.00%> (+0.16%) ⬆️
lerna/tests/test_callbacks.py 100.00% <ø> (ø)
.../test_examples/test_advanced_config_search_path.py 100.00% <ø> (ø)
...s/test_examples/test_advanced_package_overrides.py 100.00% <100.00%> (ø)
lerna/tests/test_examples/test_basic_sweep.py 100.00% <ø> (ø)
lerna/tests/test_examples/test_configure_hydra.py 100.00% <ø> (ø)
lerna/tests/test_examples/test_experimental.py 100.00% <100.00%> (ø)
...a/tests/test_examples/test_instantiate_examples.py 100.00% <ø> (ø)
lerna/tests/test_examples/test_patterns.py 100.00% <ø> (ø)
... and 20 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

On Windows, paths like C:\Users\runneradmin\Temp contain backslash
sequences that get misinterpreted as escape characters (\r, \t, etc.)
when passed through Hydra overrides. This causes WinError 123 (invalid
path syntax) when trying to create directories.

Added normalize_path_for_override() helper that converts backslashes to
forward slashes, which work on all platforms and don't have escape
sequence issues.
- Fix test_hydra_resolver_in_output_dir to use normalize_path_for_override
- Fix test_compute_output_dir to handle Windows backslash separators
@timkpaine timkpaine marked this pull request as ready for review February 21, 2026 18:07
@timkpaine timkpaine merged commit c348239 into nbprint:main Feb 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant