Naming of hints #1571
Merged
Naming of hints #1571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for example, `uncurry (curry f) -> f` mentioned only redundancy of uncurry - and `pure x *> y -> y` mentioned redundancy of pure, while `x <* pure y -> x` mentions redundancy of <*
- in accordance with `map f (map g x) -> map (f . g) x` being named "Use map once"
- e.g., in `maybe False (x ==) -> (Just x ==)` it seems more useful to mention disappearence of maybe instead of appearance of Just
- e.g., in `any f (concat x) -> any (any f) x` the default name is "Use any" which is strange since any is already used before applying the hint as well
- because corresponding hints for flip/flip, not/not, negate/negate are also not called "Avoid flip" etc. but rather "Redundant flip" ...
Owner
|
Thanks - they all look improvements to me. Great to see the incremental improvements. |
cgohla
pushed a commit
to cgohla/hlint
that referenced
this pull request
Jun 8, 2025
Summary: Test Plan:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested various renamings of hints, in ways I would consider more useful/consistent in communicating with students in particular.
The changes are distributed over several smaller commits "grouping" similar suggestions, and with brief justifications in the commit messages. To enable cherry-picking of individual suggestions/commits if need be.