feat: Added the ability to send a signed transaction from a file #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2024 20:53
Collaborator
Author
|
@FroVolod Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 5! @akorchyn received 25 Sloth Points for reviewing and scoring this pull request. What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
❌ PR inactiveThis PR has been inactive for two weeks. It's now marked as stale. Tip If you think it's a mistake, you can restart the bot with |
akorchyn
approved these changes
Dec 13, 2024
Collaborator
akorchyn
left a comment
akorchyn
left a comment
There was a problem hiding this comment.
LGTM. That's a nice feature.
One nit is a field name. Weirdly, it's a Signed transaction (serialized as base64). I don't think that it is a good name for a JSON field.
Maybe something like "signedTransactionAsBase64"
@race-of-sloths score 5
Merged
akorchyn
pushed a commit
that referenced
this pull request
Dec 16, 2024
…ned-transaction-info.json) (#427) As recommended by @akorchyn ([pull/412#pullrequestreview-2502347297](#412 (review))), the field name for the transaction information JSON file (signed-transaction-info.json) has been fixed. --------- Co-authored-by: FroVolod <[email protected]>
akorchyn
pushed a commit
that referenced
this pull request
Dec 17, 2024
## 🤖 New release * `near-cli-rs`: 0.16.1 -> 0.17.0 (⚠️ API breaking changes) ###⚠️ `near-cli-rs` breaking changes ``` --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.37.0/src/lints/struct_pub_field_missing.ron Failed in: field inner of struct SignedDelegateActionAsBase64, previously in file /tmp/.tmpAefZh2/near-cli-rs/src/types/signed_delegate_action.rs:5 --- failure struct_pub_field_now_doc_hidden: pub struct field is now #[doc(hidden)] --- Description: A pub field of a pub struct is now marked #[doc(hidden)] and is no longer part of the public API. ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.37.0/src/lints/struct_pub_field_now_doc_hidden.ron Failed in: field SignedDelegateActionAsBase64.inner in file /tmp/.tmpyy9aLz/near-cli-rs/src/types/signed_delegate_action.rs:4 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.17.0](v0.16.1...v0.17.0) - 2024-12-16 ### Added - Added the ability to send a signed meta-transaction from a file (#428) - Added the ability to send a signed transaction from a file (#412) - Added the ability to use TEACH ME mode to create an account with a faucet service sponsor (#407) ### Fixed - Fixed field name for JSON file with transaction information (signed-transaction-info.json) (#427) ### Other - add CODEOWNERS (#426) - print searched location on miss on sign-with-legacy-keychain (#422) - [**breaking**] updates near-* dependencies to 0.28 release (#423) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
eth-wardenrt
added a commit
to eth-wardenrt/near-cli-rs
that referenced
this pull request
Sep 28, 2025
…ned-transaction-info.json) (#427) As recommended by @akorchyn ([pull/412#pullrequestreview-2502347297](near/near-cli-rs#412 (review))), the field name for the transaction information JSON file (signed-transaction-info.json) has been fixed. --------- Co-authored-by: FroVolod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.