feat(routines): human-readable cron schedule summaries in web UI#1154
Merged
zmanian merged 3 commits intonearai:stagingfrom Mar 14, 2026
Merged
feat(routines): human-readable cron schedule summaries in web UI#1154zmanian merged 3 commits intonearai:stagingfrom
zmanian merged 3 commits intonearai:stagingfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Author
|
Status check: all required CI checks are green and there are no open review threads to address on this branch. Remaining blocker appears to be maintainer review/approval. |
zmanian
approved these changes
Mar 14, 2026
Collaborator
zmanian
left a comment
There was a problem hiding this comment.
Review: Human-readable cron schedule descriptions in web UI
Well-implemented feature. describe_cron() converts common cron patterns to plain English with clean fallback to raw expression.
Positives:
- Handles 5/6/7-field cron expressions
- Covers common patterns: minute/hour steps, daily, weekdays, specific weekday, monthly
- Ordinal formatting handles edge cases (11th, 12th, 13th)
- Timezone suffix when provided
- Falls back to
cron: <raw>for unrecognized patterns - Web UI shows human-readable as primary text, raw cron in tooltip
trigger_rawandtrigger_summaryadded to both list and detail API responses- Good test coverage for common patterns and edge cases
LGTM.
This was referenced Mar 15, 2026
This was referenced Mar 16, 2026
Merged
bkutasi
pushed a commit
to bkutasi/ironclaw
that referenced
this pull request
Mar 28, 2026
…rai#1154) * feat(routines): render cron triggers as human-readable summaries * test(routines): annotate multiline cron assertions for no-panics CI * test(routines): avoid multiline assert lint false positives
drchirag1991
pushed a commit
to drchirag1991/ironclaw
that referenced
this pull request
Apr 8, 2026
…rai#1154) * feat(routines): render cron triggers as human-readable summaries * test(routines): annotate multiline cron assertions for no-panics CI * test(routines): avoid multiline assert lint false positives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
describe_cron()insrc/agent/routine.rsfor common routine cron patterns (with safe fallback)trigger_rawand human-readabletrigger_summaryin routine list/detail payloadstitle) while displaying readable summaryCoverage
describe_cron()now covers common patterns including:Closes #1131
Validation
cargo fmt --allcargo test -p ironclaw test_describe_cron_common_patterns -- --nocapturecargo test -p ironclaw test_describe_cron_edge_cases -- --nocapturecargo clippy -p ironclaw --all-targets -- -D warnings