fix: resolve wasm broadcast merge conflicts with staging (#395)

[ilblackdragon]

Summary

Takeover of #395 — merges staging and fixes CI failures.

• Remove duplicate broadcast() impls from WasmChannel and SharedWasmChannel (staging already has the generic call_on_broadcast path)
• Remove obsolete telegram-specific test helper and tests that tested the old telegram-only broadcast logic
• Add test_broadcast_delegates_to_call_on_broadcast for the generic path
• Fix missing fallback_deliverable field in job_monitor test SseEvent::JobResult constructors

Supersedes #395 (original by @davidpty).

Test plan

• cargo fmt -- --check clean
• cargo clippy --all --benches --tests --examples --all-features zero warnings
• cargo test broadcast — all 14 broadcast tests pass

🤖 Generated with Claude Code

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves merge conflicts related to WASM broadcast functionality by integrating changes from staging and addressing CI failures. It streamlines the broadcast mechanism by removing duplicate implementations, cleans up outdated Telegram-specific tests, and ensures test coverage for the generic broadcast path, while also fixing a minor field omission in job monitor tests.

Highlights

• Duplicate broadcast() implementations: Removed redundant broadcast() implementations from WasmChannel and SharedWasmChannel, leveraging the generic call_on_broadcast path already present in staging.
• Obsolete Telegram-specific tests: Eliminated an obsolete Telegram-specific test helper and associated tests that targeted the old Telegram-only broadcast logic.
• New broadcast delegation test: Introduced test_broadcast_delegates_to_call_on_broadcast to verify the generic broadcast path.
• job_monitor test fix: Corrected missing fallback_deliverable field in job_monitor test SseEvent::JobResult constructors.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request resolves merge conflicts from staging, primarily related to the broadcast functionality in WASM channels. The changes include removing duplicate implementations, cleaning up obsolete tests, and adding a new test for the generic broadcast path. Additionally, it fixes compilation errors in job_monitor tests by adding the missing fallback_deliverable field. The changes are correct and improve test coverage and code consistency. I have no specific feedback on the code changes.

[Copilot]

Pull request overview

This PR resolves staging merge conflicts around WASM channel broadcast behavior and unblocks CI by aligning tests with the current generic call_on_broadcast path and updated SSE event shapes.

Changes:

• Adds a WASM wrapper regression test around broadcast() behavior.
• Updates job_monitor tests to include the newly required fallback_deliverable field in SseEvent::JobResult.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/channels/wasm/wrapper.rs	Adds a broadcast-related test and imports OutgoingResponse for test usage.
src/agent/job_monitor.rs	Fixes test constructors for SseEvent::JobResult by adding fallback_deliverable: None.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

test_broadcast_delegates_to_call_on_broadcast doesn’t actually verify delegation: with component: None, both WasmChannel::broadcast() (via call_on_broadcast short-circuit) and the Channel trait’s default broadcast() would return Ok(()). This makes the test name/intent misleading and weak as a regression test. Consider either renaming it to reflect what it asserts (e.g., broadcast succeeds with no WASM module) or strengthening it to assert non-default behavior (e.g., an observable side effect or an error condition that only the WasmChannel override can produce).