Skip to content

fix: remove auto-proceed fake user message injection#255

Merged
ilblackdragon merged 2 commits intomainfrom
fix/remove-auto-proceed-nudge
Feb 20, 2026
Merged

fix: remove auto-proceed fake user message injection#255
ilblackdragon merged 2 commits intomainfrom
fix/remove-auto-proceed-nudge

Conversation

@serrrfirat
Copy link
Copy Markdown
Collaborator

Summary

  • Remove the auto-proceed mechanism that injected fake user messages ("Please proceed and use the available tools to complete this task.") into the conversation when the LLM responded with text instead of tool calls
  • Remove resume_after_tool parameter and tools_executed tracking from run_agentic_loop
  • Text responses now return immediately, trusting the LLM to decide when tools are needed (consistent with ZeroClaw and OpenClaw)

Motivation

The nudge mechanism caused:

  • Hallucinated conversations during casual chat (fake user messages appeared in context)
  • 3x wasted LLM calls per turn (up to 2 retries before giving up)
  • Trust issues from phantom messages in conversation history

Both ZeroClaw and OpenClaw handle this by simply returning text responses immediately and relying on prompt engineering for tool use encouragement.

Closes #145

Test plan

  • cargo fmt — clean
  • cargo clippy --all --benches --tests --examples --all-features — no warnings
  • cargo test — 882 tests pass
  • Grep confirms zero remaining references to resume_after_tool, tools_executed, or "Please proceed" in agent_loop.rs

🤖 Generated with Claude Code

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

ilblackdragon
ilblackdragon previously approved these changes Feb 20, 2026
The agentic loop injected fake user messages ("Please proceed and use
the available tools to complete this task.") when the LLM responded
with text instead of tool calls. This caused hallucinated conversations
during casual chat, 3x wasted LLM calls, and trust issues.

Remove the `resume_after_tool` parameter and `tools_executed` tracking
entirely. Text responses now return immediately, trusting the LLM to
decide when tools are needed (consistent with ZeroClaw and OpenClaw).

Closes #145

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@serrrfirat serrrfirat force-pushed the fix/remove-auto-proceed-nudge branch from 45d1c67 to 4810439 Compare February 20, 2026 08:01
@github-actions github-actions Bot added size: S 10-49 changed lines risk: medium Business logic, config, or moderate-risk modules contributor: experienced 6-19 merged PRs scope: agent Agent core (agent loop, router, scheduler) labels Feb 20, 2026
@ilblackdragon ilblackdragon merged commit 8a4f3b6 into main Feb 20, 2026
4 checks passed
@ilblackdragon ilblackdragon deleted the fix/remove-auto-proceed-nudge branch February 20, 2026 08:09
@github-actions github-actions Bot mentioned this pull request Feb 20, 2026
serrrfirat added a commit that referenced this pull request Feb 20, 2026
@github-actions github-actions Bot mentioned this pull request Feb 20, 2026
jaswinder6991 pushed a commit to jaswinder6991/ironclaw that referenced this pull request Feb 26, 2026
…earai#255)

The agentic loop injected fake user messages ("Please proceed and use
the available tools to complete this task.") when the LLM responded
with text instead of tool calls. This caused hallucinated conversations
during casual chat, 3x wasted LLM calls, and trust issues.

Remove the `resume_after_tool` parameter and `tools_executed` tracking
entirely. Text responses now return immediately, trusting the LLM to
decide when tools are needed (consistent with ZeroClaw and OpenClaw).

Closes nearai#145

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
bkutasi pushed a commit to bkutasi/ironclaw that referenced this pull request Mar 28, 2026
…earai#255)

The agentic loop injected fake user messages ("Please proceed and use
the available tools to complete this task.") when the LLM responded
with text instead of tool calls. This caused hallucinated conversations
during casual chat, 3x wasted LLM calls, and trust issues.

Remove the `resume_after_tool` parameter and `tools_executed` tracking
entirely. Text responses now return immediately, trusting the LLM to
decide when tools are needed (consistent with ZeroClaw and OpenClaw).

Closes nearai#145

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: experienced 6-19 merged PRs risk: medium Business logic, config, or moderate-risk modules scope: agent Agent core (agent loop, router, scheduler) size: S 10-49 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-proceed prompting: Feature or Bug?

2 participants