Skip to content

ci: remove staging promotion pipeline#2783

Closed
serrrfirat wants to merge 1 commit into
issue-2719-pr-a-merge-queue-readyfrom
issue-2719-pr-b-staging-cleanup
Closed

ci: remove staging promotion pipeline#2783
serrrfirat wants to merge 1 commit into
issue-2719-pr-a-merge-queue-readyfrom
issue-2719-pr-b-staging-cleanup

Conversation

@serrrfirat
Copy link
Copy Markdown
Collaborator

Summary

  • delete the staging promotion workflows and helper scripts
  • remove the release-plz batch-summary flow that depended on staging promotion merge markers
  • simplify docker.yml by removing the scheduled staging image path and retiring the :staging override

Notes

Validation

  • ran git diff --check
  • parsed the edited workflow YAML locally
  • did a focused read-only review pass on the final diff

Part of #2719.

@github-actions github-actions Bot added scope: ci CI/CD workflows size: XL 500+ changed lines risk: medium Business logic, config, or moderate-risk modules contributor: core 20+ merged PRs labels Apr 21, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes two bash scripts used for updating pull request bodies with staging promotion summaries and metadata. I have no feedback to provide as there are no review comments to evaluate.

Copy link
Copy Markdown
Collaborator

@henrypark133 henrypark133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What looks good:

  • The retired staging-promotion workflows and helper scripts are removed cleanly.
  • docker.yml now explicitly rejects staging tag overrides, which matches the stated direction.
  • I did not find stale references inside this PR's actual six-file diff.

No verified findings.

Low-priority notes:

  • This PR is stacked on issue-2719-pr-a-merge-queue-ready, so rollout risk around branch triggers and required checks lives mostly in the base branch rather than in this cleanup diff itself.

Summary:

  • Recommended verdict: Comment
  • Prior feedback status: no prior review
  • Review coverage: checked-out worktree plus CI-focused diff audit
  • Residual risk: evaluate the full stack together before merge, since origin/HEAD still points to origin/staging

WORKER_TAGS="${WORKER_TAGS},${WORKER_IMAGE_NAME}:latest"
WORKER_TAGS="${WORKER_TAGS},${WORKER_IMAGE_NAME}:${SHA}"
elif [[ "${EVENT_NAME}" == "schedule" ]]; then
# Daily staging: :staging + :sha-xxx
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to completely remove the staging tag from ironclaw docker image?

I think we probably still want to keep a staging or dev tag for tracking the build from the latest commit in main branch even if we're replacing staging branch with main.

@henrypark133
Copy link
Copy Markdown
Collaborator

Closing this as superseded by #3104. The staging cleanup is folded into the main-only cutover PR so the workflow deletion and merge-queue CI contract land together from current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: medium Business logic, config, or moderate-risk modules scope: ci CI/CD workflows size: XL 500+ changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants