ci: remove staging promotion pipeline#2783
Closed
serrrfirat wants to merge 1 commit into
Closed
Conversation
Collaborator
henrypark133
left a comment
There was a problem hiding this comment.
What looks good:
- The retired staging-promotion workflows and helper scripts are removed cleanly.
docker.ymlnow explicitly rejectsstagingtag overrides, which matches the stated direction.- I did not find stale references inside this PR's actual six-file diff.
No verified findings.
Low-priority notes:
- This PR is stacked on
issue-2719-pr-a-merge-queue-ready, so rollout risk around branch triggers and required checks lives mostly in the base branch rather than in this cleanup diff itself.
Summary:
- Recommended verdict: Comment
- Prior feedback status: no prior review
- Review coverage: checked-out worktree plus CI-focused diff audit
- Residual risk: evaluate the full stack together before merge, since
origin/HEADstill points toorigin/staging
| WORKER_TAGS="${WORKER_TAGS},${WORKER_IMAGE_NAME}:latest" | ||
| WORKER_TAGS="${WORKER_TAGS},${WORKER_IMAGE_NAME}:${SHA}" | ||
| elif [[ "${EVENT_NAME}" == "schedule" ]]; then | ||
| # Daily staging: :staging + :sha-xxx |
Contributor
There was a problem hiding this comment.
Do we plan to completely remove the staging tag from ironclaw docker image?
I think we probably still want to keep a staging or dev tag for tracking the build from the latest commit in main branch even if we're replacing staging branch with main.
Collaborator
|
Closing this as superseded by #3104. The staging cleanup is folded into the main-only cutover PR so the workflow deletion and merge-queue CI contract land together from current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker.ymlby removing the scheduledstagingimage path and retiring the:stagingoverrideNotes
maindirectly rather than introducing a newdeploy/stagingtag workflow.Validation
git diff --checkPart of #2719.