feat(reborn): add memory document storage boundary#3078
Merged
serrrfirat merged 5 commits intoApr 30, 2026
Conversation
34 tasks
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ironclaw_memory crate, which provides filesystem adapters for memory documents, enabling virtual path access to database-backed storage. It includes repository implementations for PostgreSQL and libSQL that maintain compatibility with existing document schemas while enforcing tenant and project isolation. The PR also adds comprehensive documentation for the storage catalog and filesystem contracts, integrates the new crate into the workspace, and performs extensive dependency updates. I have no feedback to provide.
6 tasks
…pr-3078 # Conflicts: # Cargo.lock # Cargo.toml
Address paranoid review findings in the Reborn memory storage PR: - scope DB-backed memory rows by tenant/user/project owner key instead of encoding project scope into the relative path - preserve top-level projects/ documents for no-project memory scopes - reject file/directory prefix conflicts through the filesystem write path - treat index refresh as best-effort derived state after committed repository writes - use partial unique indexes and atomic upserts for DB-backed document writes - keep Cargo.lock diff scoped to the new ironclaw_memory package entry after merging latest reborn-integration Verification: - cargo fmt --check - cargo test -p ironclaw_memory --features libsql - cargo test -p ironclaw_memory - cargo check -p ironclaw_memory --features postgres --locked - cargo check -p ironclaw_memory --all-features --locked - cargo clippy -p ironclaw_memory --all-targets --all-features -- -D warnings - git diff --check
…pr-3078 # Conflicts: # Cargo.toml
This was referenced Apr 30, 2026
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft carve-out for PR7 from the existing Reborn memory branch material.
Adds the first memory storage/backend substrate:
Includes:
MemoryDocumentScopeandMemoryDocumentPathfor file-shaped memory documents;/memory/tenants/{tenant}/users/{user}/projects/{project}/{path}paths;Scope boundary
This intentionally does not wire production runtime memory behavior or expose user-visible behavior changes.
PR8 extends this branch with metadata/search/index/embedding/plugin seams and the agent-scoped path mapping that was present later in the old memory branch.
Verification
Passed locally:
Refs #2987.