fix(reborn): harden runtime network policy handoff#3165
Merged
serrrfirat merged 1 commit intoMay 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances security by reordering network policy retrieval to occur before request validation, ensuring one-shot policies are consumed even if validation fails. It also simplifies the WasmRuntimeCredentialRequest struct by removing the network_policy field and adds comprehensive tests for WASM, Script, and MCP adapters to verify policy consumption. I have no further feedback to provide as the existing review comments were purely explanatory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
network_policyfield fromWasmRuntimeCredentialRequestso credential providers cannot drift from the staged runtime policy handoffHostHttpEgressService + NetworkObligationPolicyStoreVerification
cargo fmt --checkcargo test -p ironclaw_wasm --test wasm_http_adapter_contractcargo test -p ironclaw_host_runtime --test runtime_http_egress_contractcargo check -p ironclaw_host_runtime -p ironclaw_wasm -p ironclaw_scripts -p ironclaw_mcp --all-targetscargo clippy -p ironclaw_host_runtime -p ironclaw_wasm -p ironclaw_scripts -p ironclaw_mcp --all-targets -- -D warningsgit diff --check