fix(ci): keep nightly e2e alert outside reusable workflow#3312
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
github-actions
Bot
added
scope: ci
[skip-regression-check]
serrrfirat
force-pushed
the
fix/main-run-tests-startup
branch
from
20540cf to
4c30395
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/e2e.ymlNightly E2Ewrapper workflow that schedules full E2E and reports issues on scheduled failuresWhy
Run Testson main has been failing at workflow startup since #3293. The reusablee2e.ymlgained a schedule-only alert job requestingissues: write. Even though the e2e jobs intest.ymlare conditional, GitHub validates the referenced reusable workflow and fails startup before creating jobs.Verification
.github/workflows/e2e.yml,.github/workflows/nightly-e2e.yml, and.github/workflows/test.ymlwith Ruby YAML parser.Expected effect: the next main push should start
Run Testsnormally instead ofstartup_failure.