feat(web): display logs newest-first in web gateway UI#369
Conversation
Reverse log display order so the most recent entries appear at the top, removing the need to scroll to see latest activity. Frontend: rename appendLogEntry to prependLogEntry, use prepend() for DOM insertion, cap oldest entries from the bottom, and auto-scroll to top. Backend: update recent_entries() doc comment to clarify the oldest-first return order works correctly with the frontend's prepend. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary of ChangesHello @henrypark133, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience of the web gateway's log viewer by reorienting the log display to show the most recent entries at the top. This change improves usability by making the latest information immediately accessible without manual scrolling, streamlining the process of monitoring real-time activity. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly implements the feature to display logs in the web UI with the newest entries appearing at the top. The frontend changes in app.js are consistent and well-executed, including renaming appendLogEntry to prependLogEntry, using prepend() for DOM insertion, and updating the logic for capping entries and auto-scrolling. The backend documentation update in log_layer.rs also provides useful clarification. Overall, the changes are sound and achieve the intended user experience improvement.
Reverse log display order so the most recent entries appear at the top, removing the need to scroll to see latest activity. Frontend: rename appendLogEntry to prependLogEntry, use prepend() for DOM insertion, cap oldest entries from the bottom, and auto-scroll to top. Backend: update recent_entries() doc comment to clarify the oldest-first return order works correctly with the frontend's prepend. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
appendLogEntry→prependLogEntry, useprepend()for DOM insertion, cap oldest entries from the bottom, auto-scroll to toprecent_entries()doc comment to clarify the oldest-first return order (which works correctly with the frontend's prepend)Test plan
cargo clippy --all --all-features— zero warningscargo test log_layer— all 12 tests pass🤖 Generated with Claude Code