-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: resolve_thread adopts existing session threads by UUID #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a potential race condition in this block that could violate the intended channel-scoped thread isolation. The check for
mapped_elsewhereis done under a read lock, which is then released. If another thread acquires a write lock and maps the sameext_uuidbefore this thread acquires its write lock for insertion, this thread will proceed to create a duplicate mapping. This would break the rule that a thread UUID should only be mapped from one channel.To fix this, you should re-check if the
ext_uuidis mapped after acquiring the write lock onthread_mapbut before inserting the new key. This double-checked locking approach ensures the check and insertion are effectively atomic with respect to other threads trying to map the same UUID.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — this is a real TOCTOU race. Applied double-checked locking: re-check
thread_map.values().any(|&v| v == ext_uuid)after acquiring the write lock. If the UUID was mapped by another task in the interim, we fall through to create a new thread instead. All 8 resolve_thread tests pass. See ecc2378.