Fix systemctl unit

[jwiklund]

Without CLI_ENABLED=false the daemon keeps restarting since the stdin is closed.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an instability issue with the daemon when it's run as a systemd service. By explicitly setting an environment variable within the service configuration, the daemon is prevented from restarting unexpectedly, ensuring its reliable operation in a production environment.

Highlights

• Systemd Service Fix: The pull request addresses a critical issue where the daemon would continuously restart when deployed as a systemd service due to stdin being closed.
• CLI Environment Variable: The fix involves adding Environment="CLI_ENABLED=false" to the systemd service unit definition in src/service.rs.

Changelog

• src/service.rs
  • Added Environment="CLI_ENABLED=false" to the systemd service unit configuration to prevent daemon restarts.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where the ironclaw daemon would continuously restart when run as a systemd service on Linux. The fix involves setting the CLI_ENABLED=false environment variable in the systemd unit file to prevent the application from trying to use stdin. My review suggests extending this fix to the macOS launchd service as well, which likely suffers from the same problem.

[gemini-code-assist]

While this disables the CLI for the systemd service, the same issue of a closed stdin likely affects the macOS launchd service. To ensure consistent behavior and prevent restart loops on macOS, you should also set CLI_ENABLED=false in the install_macos function. This can be done by adding an EnvironmentVariables dictionary to the generated plist file.

For example, you could add this to the plist's main dictionary:

<key>EnvironmentVariables</key>
<dict>
  <key>CLI_ENABLED</key>
  <string>false</string>
</dict>

[zmanian]

Review: Fix systemctl unit

Verdict: APPROVE

Without CLI_ENABLED=false in the systemd unit, the daemon tries to read from stdin (which is closed when running as a service), causing a restart loop. One-line fix, obvious correctness.

As Gemini noted, the macOS launchd plist may have the same issue -- but that's a separate concern and shouldn't block this fix.