fix(web): mobile browser bar obscures chat input#508
Conversation
…chat input On mobile browsers (Brave/Android, Safari/iOS), the bottom navigation bar covers the chat input because 100vh includes space behind browser chrome. Switch to 100dvh (dynamic viewport height) with vh fallback for older browsers, and add safe-area-inset padding for notched devices. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical UI issue on mobile devices where browser navigation bars would obscure the chat input field. By adopting modern CSS viewport units ( Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the issue of the mobile browser's bottom bar obscuring the chat input. The use of 100dvh with a 100vh fallback is the correct modern approach for handling dynamic viewport sizes. The addition of viewport-fit=cover and safe-area-inset-bottom padding is also a great implementation for handling notched devices. I have one suggestion in style.css to improve the maintainability of the padding properties for the chat input, but overall the changes are solid.
|
Fixes: #410 |
* fix(web): use dvh units to prevent mobile browser bar from obscuring chat input On mobile browsers (Brave/Android, Safari/iOS), the bottom navigation bar covers the chat input because 100vh includes space behind browser chrome. Switch to 100dvh (dynamic viewport height) with vh fallback for older browsers, and add safe-area-inset padding for notched devices. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix padding declaration in chat input style --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Illia Polosukhin <ilblackdragon@gmail.com>
Summary
100vhto100dvh(withvhfallback) onbody,#auth-screen,#app, and.job-filesso the layout sizes to the visible viewport on mobile browsersviewport-fit=coverto the viewport meta tag to enableenv(safe-area-inset-*)on notched/rounded devicespadding-bottom: max(12px, env(safe-area-inset-bottom))to.chat-inputfor devices with a home indicator barFixes the issue where mobile browser bottom navigation bars (Brave on Android, Safari on iOS) completely cover the chat input box.
Test plan
🤖 Generated with Claude Code