Skip to content

BUG: "textShadow*" style props are deprecated. Use "textShadow" #2782

@psnet

Description

@psnet

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

Using shadow textShadow* props for Text styles causes warning message in console:

"textShadow*" style props are deprecated. Use "textShadow".

but all textShadow* props still relevant and NOT deprecated:

https://reactnative.dev/docs/text-style-props#textshadowcolor
and other textShadow* props are working

Example:

const styles = StyleSheet.create({
    text: {
        textShadowOffset: {
            height: 1,
            width: 0,
        },
        textShadowRadius: 0,
        textShadowColor: '#555',
    },
});

Error located here:
https://github.com/necolas/react-native-web/blob/master/packages/react-native-web/src/exports/StyleSheet/preprocess.js#L169

More errors

Also one line

https://github.com/necolas/react-native-web/blob/master/packages/react-native-web/src/exports/StyleSheet/preprocess.js#L162

we see comma , at end of line which seems like an error

(options.textShadow === true,

the same on line

https://github.com/necolas/react-native-web/blob/master/packages/react-native-web/src/exports/StyleSheet/preprocess.js#L144

(options.shadow === true,

And these were introduced long time ago

2a901e5#diff-07ace23d03f77f7d4ac5a51d41ea9ce93ca07a9b45a7f9deeb2f199d366c2217R118

2a901e5#diff-07ace23d03f77f7d4ac5a51d41ea9ce93ca07a9b45a7f9deeb2f199d366c2217R140

Expected behavior

Warning message will not be shown

Steps to reproduce

const styles = StyleSheet.create({
    text: {
        textShadowOffset: {
            height: 1,
            width: 0,
        },
        textShadowRadius: 0,
        textShadowColor: '#555',
    },
});

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions