Skip to content

Finish the TOML support started in #699 #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2019
Merged

Finish the TOML support started in #699 #865

merged 5 commits into from
Nov 4, 2019

Conversation

nedbat
Copy link
Owner

@nedbat nedbat commented Nov 4, 2019

On top of what @RazerM did in #699, this:

  • Provides error messages for trying to use TOML when toml isn't installed.
  • Tests the no-toml-installed scenarios.
  • Expands environment variables in all TOML settings.

Squashed and rebased from #699

Missing getfloat

TOMLConfigParser -> TomlConfigParser

fix getfloat for int

Move TomlConfigParser

Add name to contributors

Import toml in backward.py

fix indentation

Don't ignore TomlDecodeError

Raise if TomlConfigParser is used without toml installed

Add tests for TOML config

Fix test on Python 2

Mention toml support in documentation.
@nedbat nedbat force-pushed the nedbat/finish-699 branch from fd8987e to 4a00e45 Compare November 4, 2019 02:27
@codecov-io
Copy link

Codecov Report

Merging #865 into master will increase coverage by 0.03%.
The diff coverage is 91.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
+ Coverage    92.2%   92.23%   +0.03%     
==========================================
  Files          85       87       +2     
  Lines       11416    11629     +213     
  Branches     1150     1176      +26     
==========================================
+ Hits        10526    10726     +200     
- Misses        746      756      +10     
- Partials      144      147       +3
Impacted Files Coverage Δ
coverage/cmdline.py 90.39% <ø> (ø) ⬆️
coverage/config.py 98.36% <100%> (+0.02%) ⬆️
coverage/backward.py 96.92% <100%> (+0.14%) ⬆️
tests/test_config.py 100% <100%> (ø) ⬆️
tests/test_testing.py 100% <100%> (ø) ⬆️
coverage/optional.py 100% <100%> (ø)
coverage/tomlconfig.py 85% <85%> (ø)
coverage/control.py 88% <0%> (+0.28%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c06204...4a00e45. Read the comment docs.

@nedbat nedbat merged commit df744f8 into master Nov 4, 2019
@nedbat nedbat deleted the nedbat/finish-699 branch November 4, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants