-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade @mui/system from 5.10.10 to 5.18.0 #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade @mui/system from 5.10.10 to 5.18.0. See this package in npm: @mui/system See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/1491b9a6-0919-43c1-8c2a-1fe24daf820a?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades @mui/system from 5.10.10 to 5.18.0. This update successfully addresses a Regular Expression Denial of Service (ReDoS) vulnerability in a transitive dependency (@babel/runtime). However, this creates a significant version mismatch with other @mui/* packages in the project, which remain on much older versions (around 5.10.x). This is against Material-UI's recommendation to keep all of their packages on the same version to avoid compatibility issues. I've added a comment with a suggestion to update all @mui v5 packages to their latest stable versions. This will not only resolve the version skew but also bring in other bug fixes and improvements from the updated packages, leading to a more stable and maintainable state.
| "@mui/icons-material": "^5.10.9", | ||
| "@mui/material": "^5.10.11", | ||
| "@mui/styles": "^5.10.10", | ||
| "@mui/system": "^5.10.10", | ||
| "@mui/system": "^5.18.0", | ||
| "@mui/x-data-grid": "^5.17.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this PR correctly updates @mui/system to fix a vulnerability, it introduces a significant version skew between @mui/system (5.18.0) and other @mui/* packages (around 5.10.x). It is a Material-UI best practice to keep all @mui packages on the same version to ensure compatibility and prevent subtle bugs.
A better approach would be to update all @mui packages to a consistent and recent version that also resolves the vulnerability. I suggest updating the core MUI v5 packages to ^5.15.20 and @mui/x-data-grid to its latest v5 patch release, ^5.17.26. This will keep your dependencies consistent and up-to-date.
| "@mui/icons-material": "^5.10.9", | |
| "@mui/material": "^5.10.11", | |
| "@mui/styles": "^5.10.10", | |
| "@mui/system": "^5.10.10", | |
| "@mui/system": "^5.18.0", | |
| "@mui/x-data-grid": "^5.17.8", | |
| "@mui/icons-material": "^5.15.20", | |
| "@mui/material": "^5.15.20", | |
| "@mui/styles": "^5.15.20", | |
| "@mui/system": "^5.15.20", | |
| "@mui/x-data-grid": "^5.17.26", |
Snyk has created this PR to upgrade @mui/system from 5.10.10 to 5.18.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 77 versions ahead of your current version.
The recommended version was released 5 months ago.
Issues fixed by the recommended upgrade:
SNYK-JS-BABELRUNTIME-10044504
Release notes
Package name: @mui/system
-
5.18.0 - 2025-07-08
- Backport CSS layers from v7 (#46320) @ siriwatknp
- Backport CSS layers from v7 (#46320) @ siriwatknp
- Ease migration to v5 (#45991) @ oliviertassinari
- Add AccordionSummary to the breaking change migration (@ siriwatknp) (#45972) @ siriwatknp
-
5.17.1 - 2025-03-18
-
5.16.14 - 2025-01-06
-
5.16.13 - 2024-12-25
-
5.16.12 - 2024-12-17
-
5.16.8 - 2024-11-28
-
5.16.7 - 2024-08-09
-
5.16.6 - 2024-07-30
-
5.16.5 - 2024-07-25
-
5.16.4 - 2024-07-16
-
5.16.2 - 2024-07-16
-
5.16.1 - 2024-07-11
-
5.16.0 - 2024-07-05
-
5.15.20 - 2024-06-12
-
5.15.15 - 2024-04-04
-
5.15.14 - 2024-03-19
-
5.15.13 - 2024-03-13
-
5.15.12 - 2024-03-05
-
5.15.11 - 2024-02-24
-
5.15.9 - 2024-02-08
-
5.15.8 - 2024-02-06
-
5.15.7 - 2024-01-31
-
5.15.6 - 2024-01-22
-
5.15.5 - 2024-01-17
-
5.15.4 - 2024-01-10
-
5.15.3 - 2024-01-03
-
5.15.2 - 2023-12-25
-
5.15.1 - 2023-12-19
-
5.15.0 - 2023-12-12
-
5.14.20 - 2023-12-05
-
5.14.19 - 2023-11-29
-
5.14.18 - 2023-11-14
-
5.14.17 - 2023-11-06
-
5.14.16 - 2023-10-31
-
5.14.15 - 2023-10-24
-
5.14.14 - 2023-10-17
-
5.14.13 - 2023-10-10
-
5.14.12 - 2023-10-04
-
5.14.11 - 2023-09-26
-
5.14.10 - 2023-09-18
-
5.14.9 - 2023-09-13
-
5.14.8 - 2023-09-05
-
5.14.7 - 2023-08-29
-
5.14.6 - 2023-08-24
-
5.14.5 - 2023-08-14
-
5.14.4 - 2023-08-08
-
5.14.3 - 2023-08-01
-
5.14.1 - 2023-07-19
-
5.14.0 - 2023-07-11
-
5.13.7 - 2023-07-04
-
5.13.6 - 2023-06-23
-
5.13.5 - 2023-06-12
-
5.13.2 - 2023-05-22
-
5.13.1 - 2023-05-17
-
5.12.3 - 2023-05-02
-
5.12.1 - 2023-04-17
-
5.12.0 - 2023-04-11
-
5.11.16 - 2023-04-04
-
5.11.15 - 2023-03-28
-
5.11.14 - 2023-03-21
-
5.11.13 - 2023-03-14
-
5.11.12 - 2023-03-06
-
5.11.11 - 2023-02-28
-
5.11.9 - 2023-02-14
-
5.11.8 - 2023-02-07
-
5.11.7 - 2023-01-31
-
5.11.5 - 2023-01-18
-
5.11.4 - 2023-01-09
-
5.11.2 - 2022-12-26
-
5.11.1 - 2022-12-20
-
5.11.0 - 2022-12-13
-
5.10.17 - 2022-12-06
-
5.10.16 - 2022-11-28
-
5.10.15 - 2022-11-22
-
5.10.14 - 2022-11-15
-
5.10.13 - 2022-11-07
-
5.10.12 - 2022-10-31
-
5.10.10 - 2022-10-18
from @mui/system GitHub release notesA big thanks to the 2 contributors who made this release possible.
CSS layers make it easier to override styles by splitting a single style sheet into multiple layers.
To learn more, check out the CSS layers documentation.
@ mui/[email protected]@ mui/[email protected]Docs
All contributors of this release in alphabetical order: @ oliviertassinari, @ siriwatknp
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: