Skip to content

Conversation

@nejidevelops
Copy link
Owner

snyk-top-banner

Snyk has created this PR to upgrade @mui/system from 5.10.10 to 5.18.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 77 versions ahead of your current version.

  • The recommended version was released 5 months ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-BABELRUNTIME-10044504
666 Proof of Concept
Release notes
Package name: @mui/system
  • 5.18.0 - 2025-07-08

    A big thanks to the 2 contributors who made this release possible.

    CSS layers make it easier to override styles by splitting a single style sheet into multiple layers.
    To learn more, check out the CSS layers documentation.

    @ mui/[email protected]

    @ mui/[email protected]

    Docs

    All contributors of this release in alphabetical order: @ oliviertassinari, @ siriwatknp

  • 5.17.1 - 2025-03-18
  • 5.16.14 - 2025-01-06
  • 5.16.13 - 2024-12-25
  • 5.16.12 - 2024-12-17
  • 5.16.8 - 2024-11-28
  • 5.16.7 - 2024-08-09
  • 5.16.6 - 2024-07-30
  • 5.16.5 - 2024-07-25
  • 5.16.4 - 2024-07-16
  • 5.16.2 - 2024-07-16
  • 5.16.1 - 2024-07-11
  • 5.16.0 - 2024-07-05
  • 5.15.20 - 2024-06-12
  • 5.15.15 - 2024-04-04
  • 5.15.14 - 2024-03-19
  • 5.15.13 - 2024-03-13
  • 5.15.12 - 2024-03-05
  • 5.15.11 - 2024-02-24
  • 5.15.9 - 2024-02-08
  • 5.15.8 - 2024-02-06
  • 5.15.7 - 2024-01-31
  • 5.15.6 - 2024-01-22
  • 5.15.5 - 2024-01-17
  • 5.15.4 - 2024-01-10
  • 5.15.3 - 2024-01-03
  • 5.15.2 - 2023-12-25
  • 5.15.1 - 2023-12-19
  • 5.15.0 - 2023-12-12
  • 5.14.20 - 2023-12-05
  • 5.14.19 - 2023-11-29
  • 5.14.18 - 2023-11-14
  • 5.14.17 - 2023-11-06
  • 5.14.16 - 2023-10-31
  • 5.14.15 - 2023-10-24
  • 5.14.14 - 2023-10-17
  • 5.14.13 - 2023-10-10
  • 5.14.12 - 2023-10-04
  • 5.14.11 - 2023-09-26
  • 5.14.10 - 2023-09-18
  • 5.14.9 - 2023-09-13
  • 5.14.8 - 2023-09-05
  • 5.14.7 - 2023-08-29
  • 5.14.6 - 2023-08-24
  • 5.14.5 - 2023-08-14
  • 5.14.4 - 2023-08-08
  • 5.14.3 - 2023-08-01
  • 5.14.1 - 2023-07-19
  • 5.14.0 - 2023-07-11
  • 5.13.7 - 2023-07-04
  • 5.13.6 - 2023-06-23
  • 5.13.5 - 2023-06-12
  • 5.13.2 - 2023-05-22
  • 5.13.1 - 2023-05-17
  • 5.12.3 - 2023-05-02
  • 5.12.1 - 2023-04-17
  • 5.12.0 - 2023-04-11
  • 5.11.16 - 2023-04-04
  • 5.11.15 - 2023-03-28
  • 5.11.14 - 2023-03-21
  • 5.11.13 - 2023-03-14
  • 5.11.12 - 2023-03-06
  • 5.11.11 - 2023-02-28
  • 5.11.9 - 2023-02-14
  • 5.11.8 - 2023-02-07
  • 5.11.7 - 2023-01-31
  • 5.11.5 - 2023-01-18
  • 5.11.4 - 2023-01-09
  • 5.11.2 - 2022-12-26
  • 5.11.1 - 2022-12-20
  • 5.11.0 - 2022-12-13
  • 5.10.17 - 2022-12-06
  • 5.10.16 - 2022-11-28
  • 5.10.15 - 2022-11-22
  • 5.10.14 - 2022-11-15
  • 5.10.13 - 2022-11-07
  • 5.10.12 - 2022-10-31
  • 5.10.10 - 2022-10-18
from @mui/system GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade @mui/system from 5.10.10 to 5.18.0.

See this package in npm:
@mui/system

See this project in Snyk:
https://app.snyk.io/org/newtonombese1/project/1491b9a6-0919-43c1-8c2a-1fe24daf820a?utm_source=github&utm_medium=referral&page=upgrade-pr
@gemini-code-assist
Copy link

Summary of Changes

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, updates the @mui/system package to its latest recommended version, 5.18.0. The primary motivations are to resolve a critical Regular Expression Denial of Service (ReDoS) vulnerability and to keep project dependencies current for better maintenance. This update also introduces the new CSS layers feature, backported from MUI v7, which can improve styling flexibility and organization.

Highlights

  • Core Dependency Upgrade: The @mui/system package has been upgraded from version 5.10.10 to 5.18.0, representing a significant jump of 77 versions.
  • Security Vulnerability Fixed: This upgrade addresses a critical Regular Expression Denial of Service (ReDoS) vulnerability identified as SNYK-JS-BABELRUNTIME-10044504, which had a score of 666.
  • New Feature: CSS Layers: Version 5.18.0 of @mui/system introduces the backporting of CSS layers from MUI v7, offering enhanced styling capabilities and more flexible style overrides.
  • Transitive Dependency Updates: Numerous related transitive dependencies, including @babel/runtime, various @emotion/* packages, and @mui/* utilities, have also been updated to ensure compatibility and incorporate their respective improvements and fixes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, upgrades @mui/system from 5.10.10 to 5.18.0. This update successfully addresses a Regular Expression Denial of Service (ReDoS) vulnerability in a transitive dependency (@babel/runtime). However, this creates a significant version mismatch with other @mui/* packages in the project, which remain on much older versions (around 5.10.x). This is against Material-UI's recommendation to keep all of their packages on the same version to avoid compatibility issues. I've added a comment with a suggestion to update all @mui v5 packages to their latest stable versions. This will not only resolve the version skew but also bring in other bug fixes and improvements from the updated packages, leading to a more stable and maintainable state.

Comment on lines 17 to 21
"@mui/icons-material": "^5.10.9",
"@mui/material": "^5.10.11",
"@mui/styles": "^5.10.10",
"@mui/system": "^5.10.10",
"@mui/system": "^5.18.0",
"@mui/x-data-grid": "^5.17.8",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this PR correctly updates @mui/system to fix a vulnerability, it introduces a significant version skew between @mui/system (5.18.0) and other @mui/* packages (around 5.10.x). It is a Material-UI best practice to keep all @mui packages on the same version to ensure compatibility and prevent subtle bugs.

A better approach would be to update all @mui packages to a consistent and recent version that also resolves the vulnerability. I suggest updating the core MUI v5 packages to ^5.15.20 and @mui/x-data-grid to its latest v5 patch release, ^5.17.26. This will keep your dependencies consistent and up-to-date.

Suggested change
"@mui/icons-material": "^5.10.9",
"@mui/material": "^5.10.11",
"@mui/styles": "^5.10.10",
"@mui/system": "^5.10.10",
"@mui/system": "^5.18.0",
"@mui/x-data-grid": "^5.17.8",
"@mui/icons-material": "^5.15.20",
"@mui/material": "^5.15.20",
"@mui/styles": "^5.15.20",
"@mui/system": "^5.15.20",
"@mui/x-data-grid": "^5.17.26",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants