-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade @mui/styles from 5.10.10 to 5.18.0 #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade @mui/styles from 5.10.10 to 5.18.0. See this package in npm: @mui/styles See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/1491b9a6-0919-43c1-8c2a-1fe24daf820a?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant upgrade of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades @mui/styles from version 5.10.10 to 5.18.0. This is an automated update from Snyk to resolve a security vulnerability (ReDoS) in a transitive dependency, @babel/runtime. While merging this PR is recommended to patch the vulnerability, I've identified some significant concerns with the project's dependency setup that should be addressed for long-term maintainability:
- Deprecated Package: The upgraded package,
@mui/styles, is deprecated in MUI v5. A migration to a modern styling solution like@mui/systemor Emotion is highly recommended. - Mixed MUI Versions: The project includes dependencies from both Material-UI v4 (
@material-ui/*) and MUI v5 (@mui/*). Using two major versions of a UI library simultaneously is strongly discouraged as it can lead to a bloated bundle size, inconsistent styling, and potential runtime conflicts.
I've added a specific comment on the package.json change regarding the deprecated package. I strongly recommend creating follow-up tasks to migrate fully to MUI v5 and to move away from @mui/styles.
| "@mui/icons-material": "^5.10.9", | ||
| "@mui/material": "^5.10.11", | ||
| "@mui/styles": "^5.10.10", | ||
| "@mui/styles": "^5.18.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this upgrade is necessary to patch a security vulnerability, it's important to be aware that @mui/styles is a deprecated package in MUI v5. The official MUI documentation recommends migrating to a different styling solution like @mui/system (which is already a dependency in this project) or Emotion (@emotion/react).
Given that the project also has dependencies on the older @material-ui/core (v4), a broader migration effort to consolidate on MUI v5 and remove deprecated packages like this one would significantly improve the project's health and maintainability.
Snyk has created this PR to upgrade @mui/styles from 5.10.10 to 5.18.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 76 versions ahead of your current version.
The recommended version was released 5 months ago.
Issues fixed by the recommended upgrade:
SNYK-JS-BABELRUNTIME-10044504
Release notes
Package name: @mui/styles
-
5.18.0 - 2025-07-08
- Backport CSS layers from v7 (#46320) @ siriwatknp
- Backport CSS layers from v7 (#46320) @ siriwatknp
- Ease migration to v5 (#45991) @ oliviertassinari
- Add AccordionSummary to the breaking change migration (@ siriwatknp) (#45972) @ siriwatknp
-
5.17.1 - 2025-03-18
-
5.17.0 - 2025-03-18
-
5.16.14 - 2025-01-06
-
5.16.13 - 2024-12-25
-
5.16.12 - 2024-12-17
-
5.16.11 - 2024-12-11
-
5.16.10 - 2024-12-11
-
5.16.9 - 2024-12-04
-
5.16.8 - 2024-11-28
-
5.16.7 - 2024-08-09
-
5.16.6 - 2024-07-30
-
5.16.5 - 2024-07-25
-
5.16.4 - 2024-07-16
-
5.16.3 - 2024-07-16
-
5.16.2 - 2024-07-16
-
5.16.1 - 2024-07-11
-
5.16.0 - 2024-07-05
-
5.15.21 - 2024-06-28
-
5.15.20 - 2024-06-12
-
5.15.19 - 2024-05-29
-
5.15.18 - 2024-05-16
-
5.15.17 - 2024-05-08
-
5.15.16 - 2024-05-01
-
5.15.15 - 2024-04-04
-
5.15.14 - 2024-03-19
-
5.15.13 - 2024-03-13
-
5.15.12 - 2024-03-05
-
5.15.11 - 2024-02-24
-
5.15.10 - 2024-02-12
-
5.15.9 - 2024-02-08
-
5.15.8 - 2024-02-06
-
5.15.7 - 2024-01-31
-
5.15.6 - 2024-01-22
-
5.15.5 - 2024-01-17
-
5.15.4 - 2024-01-10
-
5.15.3 - 2024-01-03
-
5.15.2 - 2023-12-25
-
5.15.1 - 2023-12-19
-
5.15.0 - 2023-12-12
-
5.14.20 - 2023-12-05
-
5.14.19 - 2023-11-29
-
5.14.18 - 2023-11-14
-
5.14.17 - 2023-11-06
-
5.14.16 - 2023-10-31
-
5.14.15 - 2023-10-24
-
5.14.14 - 2023-10-17
-
5.14.13 - 2023-10-10
-
5.14.12 - 2023-10-04
-
5.14.11 - 2023-09-26
-
5.14.10 - 2023-09-18
-
5.14.9 - 2023-09-13
-
5.14.7 - 2023-08-29
-
5.14.6 - 2023-08-24
-
5.14.5 - 2023-08-14
-
5.14.4 - 2023-08-08
-
5.14.3 - 2023-08-01
-
5.14.1 - 2023-07-19
-
5.14.0 - 2023-07-11
-
5.13.7 - 2023-07-04
-
5.13.2 - 2023-05-22
-
5.13.1 - 2023-05-17
-
5.12.3 - 2023-05-02
-
5.12.0 - 2023-04-11
-
5.11.16 - 2023-04-04
-
5.11.13 - 2023-03-14
-
5.11.12 - 2023-03-06
-
5.11.11 - 2023-02-28
-
5.11.9 - 2023-02-14
-
5.11.7 - 2023-01-31
-
5.11.2 - 2022-12-26
-
5.11.1 - 2022-12-20
-
5.11.0 - 2022-12-13
-
5.10.16 - 2022-11-28
-
5.10.15 - 2022-11-22
-
5.10.14 - 2022-11-15
-
5.10.10 - 2022-10-18
from @mui/styles GitHub release notesA big thanks to the 2 contributors who made this release possible.
CSS layers make it easier to override styles by splitting a single style sheet into multiple layers.
To learn more, check out the CSS layers documentation.
@ mui/[email protected]@ mui/[email protected]Docs
All contributors of this release in alphabetical order: @ oliviertassinari, @ siriwatknp
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: