remove PerformWrites, add byte[] and dependency updates#59
Open
sarmbruster wants to merge 2 commits intoneo4j-contrib:masterfrom
Open
remove PerformWrites, add byte[] and dependency updates#59sarmbruster wants to merge 2 commits intoneo4j-contrib:masterfrom
sarmbruster wants to merge 2 commits intoneo4j-contrib:masterfrom
Conversation
Author
|
I'd appreciate a new sproc release so we can update apoc approriately once this has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a new function in APOC that returns byte[] we need to update the sproc compiler as well.
Part of that is an update to newest Neo4j version and other dependency updates (mostly to be ready to switch to JDK 11 at some point in future).
I've also removed support for
@PerformsWritesannotations since it's deprecated for a long time in Neo4j.Please note that I haven't worked a lot with with sproc-compiler, so please take a careful look if my changes do make sense.