Adding tests for SSL config options #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
changed the title
Added feature flags * `API_SSL_CONFIG = "Feature:API:SSLCon` * `API_SSL_SCHEMES = "Feature:API:SSLSchemes"`
robsdedude
force-pushed
the
ssl-options
branch
from
36de3e0 to
59be11b
Compare
robsdedude
changed the title
fbiville
reviewed
Oct 4, 2021
| with self.subTest(scheme | ||
| + "-" + str(driver_config)): | ||
| self._start_server("thehost_expired") | ||
| self.assertFalse(self._try_connect(scheme, "thehost", |
There was a problem hiding this comment.
would it be worth asserting the error as well? (I know it's currently not easy since try_connect just "passes" on the error... maybe add an optional assertion callback?)
There was a problem hiding this comment.
I'll put that onto a Trello card and define it as out of scope of this PR. I need to wrap this work up for now. Other tasks gained higher priority. internal link
robsdedude
commented
Oct 4, 2021
Co-authored-by: Florent Biville <[email protected]>
injectives
reviewed
Oct 6, 2021
injectives
reviewed
Oct 6, 2021
injectives
force-pushed
the
ssl-options
branch
5 times, most recently
from
d88b471 to
e3c482e
Compare
injectives
force-pushed
the
ssl-options
branch
5 times, most recently
from
e3d93fb to
90f7915
Compare
injectives
force-pushed
the
ssl-options
branch
from
90f7915 to
bad6bb4
Compare
injectives
force-pushed
the
ssl-options
branch
from
bad6bb4 to
20aed2c
Compare
injectives
force-pushed
the
ssl-options
branch
from
f6433f3 to
4066f76
Compare
injectives
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.