Update tests for 5.0 handshake #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbiville
force-pushed
the
5.0_handshake
branch
2 times, most recently
from
b177430 to
81cc50a
Compare
fbiville
force-pushed
the
5.0_handshake
branch
from
81cc50a to
a944a5b
Compare
robsdedude
reviewed
Jan 31, 2022
robsdedude
reviewed
Jan 31, 2022
robsdedude
reviewed
Jan 31, 2022
robsdedude
reviewed
Jan 31, 2022
fbiville
force-pushed
the
5.0_handshake
branch
from
a944a5b to
a9efd7a
Compare
robsdedude
approved these changes
Feb 28, 2022
Closed
bigmontz
force-pushed
the
5.0_handshake
branch
2 times, most recently
from
14b1e75 to
169cdec
Compare
Official drivers will not support 4.0, even with the extended 5.0 handshake. Tests requiring 4.0 are either: - removed (when variants for other 4.x are defined) - changed so that they require 4.4 (since 4.4 is the lowest 4.x version official drivers MUST support - other 4.x are optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the 4.0 Bolt feature flag. If that PR is merged first, drivers will send the 4.0 flag which will be deemed invalid and cause an error.
Therefore, merge the following PRs first: