Skip to content

Add Bolt 5.7: GQL-compliant errors #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Oct 4, 2024
Merged

Add Bolt 5.7: GQL-compliant errors #629

merged 24 commits into from
Oct 4, 2024

Conversation

MaxAake
Copy link
Contributor

@MaxAake MaxAake commented Sep 24, 2024

For testing against during implementation of GQL errors

@MaxAake MaxAake self-assigned this Sep 24, 2024
@robsdedude robsdedude force-pushed the bolt-5x7-and-gql-errors branch from 932adde to 89fd54d Compare September 25, 2024 15:52
"OPERATION": None,
"CURRENT_SCHEMA": {"uh": "oh!"},
"OPERATION_CODE": False,
"_classification": 42,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure. If this is not string, we stringify it for the getRawClassification method. Right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made it optional in Python and decided to return None if it's either missing from the diag. record or isn't a string.

@robsdedude robsdedude marked this pull request as ready for review October 3, 2024 15:08
Copy link
Contributor

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍄

@robsdedude robsdedude merged commit 4383c3f into 5.0 Oct 4, 2024
8 checks passed
@robsdedude robsdedude deleted the bolt-5x7-and-gql-errors branch October 4, 2024 13:46
@robsdedude robsdedude changed the title bolt 5x7 GQL error tests Add Bolt 5.7: GQL-compliant errors Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants