Skip to content

Commit neo4j-driver-deno to the repository #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

bigmontz
Copy link
Contributor

@bigmontz bigmontz commented Oct 5, 2022

The deno driver is generated using a custom script made for this repository.
This script doesn't have any tests linked to it.
So the only way this changes are tested is by running the deno driver test suite.
For guarantee the behaviour of this driver, we should version commit the generated driver to the repository.

This changes introduce the first committed version of the driver.
Adding the verification if the committed deno driver is in sync with the lite driver is also part of the this scope.

@bigmontz bigmontz force-pushed the 5.0-commit-deno-driver branch from 0a4f951 to ded7fde Compare October 5, 2022 15:35
The `deno` driver is generated using a custom script made for this repository.
This script doesn't have any tests linked to it.
So the only way this changes are tested is by running the `deno driver` test suite.
For guarantee the behaviour of this driver, we should version commit the generated driver to the repository.

This changes introduce the first commited version of the driver.
Adding the verification if the commited deno driver is in sync with the lite driver is also part of the this scope.
@bigmontz bigmontz force-pushed the 5.0-commit-deno-driver branch from ded7fde to 286fc1a Compare October 5, 2022 16:25
@bigmontz bigmontz marked this pull request as ready for review October 6, 2022 08:31
Copy link

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As requested just looked at the first smaller commit. Looks sensible to me.

@bigmontz bigmontz merged commit ec1af19 into neo4j:5.0 Oct 6, 2022
@bigmontz bigmontz deleted the 5.0-commit-deno-driver branch October 6, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants