-
Notifications
You must be signed in to change notification settings - Fork 149
Database Notification Improvements #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4e892a2
to
7e955e6
Compare
457324d
to
362b141
Compare
if (notificationFilters != null) { | ||
const error = newError( | ||
'Driver is connected to the database that does not support user notification filters. ' + | ||
'Please upgrade to neo4j 5.3.0 or later in order to use this functionality. ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not yet clear if this feature will make it into 5.3 or later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will hold this comment/pr until we have the functionality merged in the server and we know which version it will be part of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 just make sure to not forget to update the parts of the PR that mention the version (also some doc comments).
@@ -216,7 +216,9 @@ class SessionConfig { | |||
* // using default server configuration | |||
* const sessionWithSeverDefaultNotifications = driver.session({ database:'neo4j', notificationFilters: neo4j.notificationFilter.serverDefault() }) | |||
* // EQUIVALENT TO: const sessionWithSeverDefaultNotifications = driver.session({ database:'neo4j', notificationFilters: ["SERVER_DEFAULT"] }) | |||
* // OR SIMPLY: const sessionWithSeverDefaultNotifications = driver.session({ database:'neo4j' }) | |||
* | |||
* // using default configured in the connection/driver configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* // using default configured in the connection/driver configuration | |
* // using whatever filters were configured for the {@link Driver} (default behavior) |
Co-authored-by: Robsdedude <[email protected]>
Replaced by #1064 |
Cypher are improving the notifications that are produced by query execution by making it configurable what level of notifications can be returned and adding additional information to notifications.
Usage:
More details in the methods documentation and type signature.