Fix Integer primitive type representation #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the scenarion where: ```javascript const one = neo4j.int(1) const two = neo4j.int(2) ``` The following operations was resulting in string concatenation: ```javascript console.log( one + two ) // '12' console.log( 1 + one ) // '11' console.log( one.add(two).toInt() ) // 3, which is correct console.log( '1' + one) // '11', correct ``` This is issue is solved by defining the method `Integer.valueOf` which defines the primitive type representation. The primitive representation of `Integer` is set as `BigInt`. This way: ```javascript console.log (one + two ) // 3n console.log ( 1 + one ) // thrown an exception since we can not add bigint to number console.log ( 1n + one ) // 2n console.log ( -one ) // -1n console.log( '1' + one) // '11', correct ```
fbiville
approved these changes
Jan 2, 2023
Co-authored-by: Florent Biville <[email protected]>
bigmontz
added a commit
to bigmontz/neo4j-javascript-driver
that referenced
this pull request
Jan 9, 2023
Given the scenario where: ```javascript const one = neo4j.int(1) const two = neo4j.int(2) ``` The following operations was resulting in string concatenation: ```javascript console.log( one + two ) // '12' console.log( 1 + one ) // '11' console.log( one.add(two).toInt() ) // 3, which is correct console.log( '1' + one ) // '11', correct ``` This is issue is solved by defining the method `Integer.valueOf` which defines the primitive type representation. The primitive representation of `Integer` is set as `BigInt`. This way: ```javascript console.log( one + two ) // 3n console.log( 1 + one ) // thrown an exception since we can not add bigint to number console.log( 1n + one ) // 2n console.log( -one ) // -1n console.log( '1' + one ) // '11', correct ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the scenario where:
The following operations was resulting in string concatenation:
This is issue is solved by defining the method
Integer.valueOfwhich defines the primitive type representation. The primitive representation ofIntegeris set asBigInt.This way: