Skip to content

Release BookmarkManager and Driver.executeQuery #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bigmontz
Copy link
Contributor

@bigmontz bigmontz commented Apr 4, 2023

These new APIs are ready to be released in the Javascript Driver 5.8. This change remove the experimental tags from related APIs while makes the final adjustments to the API.

neo4j.routing.WRITERS and neo4j.routing.READERS were renamed to neo4j.routing.WRITE and neo4j.routing.READ, respectively. Or, 'WRITE'/'READ' in plain string.

Driver.defaultExecuteQueryBookmarkManager was renamed to Driver.executeQueryBookmarkManager.

Copy link

@AndyHeap-NeoTech AndyHeap-NeoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks correct to me.

Copy link
Member

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release the kraken 🐙... I mean new API!

These new APIs are ready to be released in the Javascript Driver 5.8.
This change remove the experimental tags from related APIs while makes the final adjustements to the API.

`neo4j.routing.WRITERS` and `neo4j.routing.READERS` were renamed to `neo4j.routing.WRITER` and `neo4j.routing.READ`, respectively.
Or, `'WRITE'`/`'READ'` in plain string.

`Driver.defaultExecuteQueryBookmarkManager` was renamed to `Driver.executeQueryBookmarkManager`.
@bigmontz bigmontz force-pushed the 5.x-remove-exp-from-bmm-and-execute-query branch from 8b89175 to 741b746 Compare April 5, 2023 22:13
@bigmontz bigmontz merged commit f212ff1 into neo4j:5.0 Apr 6, 2023
@bigmontz bigmontz deleted the 5.x-remove-exp-from-bmm-and-execute-query branch April 6, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants