Fix build in Node 18 #1087
Merged
Fix build in Node 18 #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build was broken because `source-map` was not working for generate resources using `ts-typescript` in `neo4j-driver`. The same was happening for running unit tests in `neo4j-driver-core`. `source-map` released a patch with the fix and applying the patch solves the issue. `webpack` version was also bumped.
ConorNeo
approved these changes
May 24, 2023
ConorNeo
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build was broken because
source-mapwas not working for generate resources usingts-typescriptinneo4j-driver. The same was happening for running unit tests inneo4j-driver-core.source-mapreleased a patch with the fix and applying the patch solves the issue.webpackversion was also bumped.