Skip to content

Make bolt agent an object in integration tests #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 7, 2023
Merged

Make bolt agent an object in integration tests #1092

merged 8 commits into from
Jun 7, 2023

Conversation

ConorNeo
Copy link
Contributor

@ConorNeo ConorNeo commented Jun 6, 2023

No description provided.

@ConorNeo ConorNeo force-pushed the fix-bolt-agent-integration-tests branch from 4922988 to 818f31f Compare June 6, 2023 10:13
thelonelyvulpes
thelonelyvulpes approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@thelonelyvulpes thelonelyvulpes changed the title Make bolt agent an object in intergration tests Make bolt agent an object in integration tests Jun 6, 2023
bigmontz
bigmontz requested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need revert the change on the examples test.

bigmontz
bigmontz approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦

bigmontz
bigmontz reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might solve the issue with this test.

@bigmontz bigmontz merged commit 5127f3a into neo4j:5.0 Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigmontz bigmontz bigmontz approved these changes

@thelonelyvulpes thelonelyvulpes thelonelyvulpes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ConorNeo @bigmontz @thelonelyvulpes