Skip to content

Introduce testcontainers for integration tests #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Aug 9, 2023

Conversation

bigmontz
Copy link
Contributor

@bigmontz bigmontz commented Aug 4, 2023

testcontainers replaces boltkit as library to start docker containers.

The container should be able to start when npm run test, npm run test::integration and npm run test::browser are run if methods are not called from testkit.

Running the tests direct from the IDE should be also an supported usecase.

  • npm run test::integration
  • npm run test
  • npm run test::browser
  • Don't conflict with testkit
  • Start container for run tests from IDE (lite-driver)
  • Start container for run tests from IDE (driver)

@bigmontz bigmontz force-pushed the 5.x-testcontainers branch from a3466bd to d4a6d02 Compare August 4, 2023 13:12
bigmontz and others added 4 commits August 4, 2023 15:15
`testcontainers` replaces `boltkit` as library to start docker containers.

The container should be able to start when `npm run test`, `npm run test::integration` and `npm run test::browser` are run if methods are not called from testkit.

Running the tests direct from the IDE should be also an supported usecase.
Co-Authored-by: Conor Watson <[email protected]>
@bigmontz bigmontz force-pushed the 5.x-testcontainers branch from d4a6d02 to c4536fe Compare August 4, 2023 13:15
@bigmontz bigmontz force-pushed the 5.x-testcontainers branch from 175d4f5 to e45721c Compare August 8, 2023 14:51
@bigmontz bigmontz marked this pull request as ready for review August 8, 2023 15:12
@bigmontz bigmontz merged commit b1fd33c into neo4j:5.0 Aug 9, 2023
@bigmontz bigmontz deleted the 5.x-testcontainers branch August 9, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants