Open
Conversation
This method was doing expensive object comparison for objects when connection auth token is null. This causes a performance penalty on the driver.
Contributor
|
@bigmontz is there some kind of policy who and what can be reviewed by non-neo4j engineers? If it allows for I could very well imagine starting to tinker more with the driver and maybe assist you with some reviews for smaller MRs (such as this one), if my time permits. PS: Sorry if this is kinda off-topic regarding this MR, wasn't really sure where to post this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was doing expensive object comparison for objects when connection auth token is null.
This causes a performance penalty on the driver.