Properly handle multiple trusted certs #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/internal/tls.test.js
Outdated
| driver = neo4j.driver("bolt://localhost", neo4j.auth.basic("neo4j", "neo4j"), { | ||
| encrypted: true, | ||
| trust: "TRUST_SIGNED_CERTIFICATES", | ||
| trustedCertificates: ["build/neo4j/certificates/neo4j.cert", "build/neo4j/certificates/neo4j.cert"] |
There was a problem hiding this comment.
Not sure if this matters, but you are passing in the same certificate path twice. Also the logic in this PR shouldn't change syntactically, the before/after change code means essentially the same?
Contributor
Author
There was a problem hiding this comment.
I was mostly being lazy, I just wanted to test that you can supply multiple certificates, but you're right it does make the test slightly confusing. I'll fix it.
No this PR should not change anything, only fixing the bad usage of map
pontusmelke
force-pushed
the
1.0-handle-multiple-ca
branch
from
e9f56a2 to
8cd6c56
Compare
pontusmelke
force-pushed
the
1.0-handle-multiple-ca
branch
from
8cd6c56 to
adc1727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105