Skip to content

Fix handshake manifest parsing of future bolt versions #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

MaxAake
Copy link
Contributor

@MaxAake MaxAake commented Feb 11, 2025

When checking the whitelist of available bolt protocols, the versions are parsed as floats, which leads to the future version 5.10 being marked as "available" since it is seen as the same as 5.1.

The fix is simple and makes the code simpler, treating them as strings in this step instead.

Copy link
Member

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"✍️"

@MaxAake MaxAake merged commit 38851e3 into 5.0 Feb 12, 2025
37 checks passed
@MaxAake MaxAake deleted the fix-future-bolt-parsing branch February 12, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants