[5.x] Make neo4j-driver export isRetriableError #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
approved these changes
Jul 30, 2025
Member
robsdedude
left a comment
robsdedude
left a comment
There was a problem hiding this comment.
Probably not worth the hassle now, but as a future improvement: feels like a test should've caught a broken export.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making isRetryableError work would cause the name to differ between neo4j-driver and neo4j-driver-lite, which would be a major headache. instead isRetriable is made to work properly in 5.x, and will be deprecated in 6.0.0
cherry picks: #1305