Skip to content

Fix: Structure error has bad .toString() #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Fix: Structure error has bad .toString() #203

merged 1 commit into from
Feb 16, 2017

Conversation

legraphista
Copy link
Contributor

Fixes issue where Structure.toString() outputs: Structure(127, [[object Object]])
Now it should properly stringify the error: Structure(127, [{"code":"Neo.ClientError.Statement.ArithmeticError","message":"/ by zero"}])

Fixes issue where Structure.toString() outputs: `Structure(127, [[object Object]])`
Now it should properly stringify the error:  `Structure(127, [{"code":"Neo.ClientError.Statement.ArithmeticError","message":"/ by zero"}])`
@legraphista
Copy link
Contributor Author

I've noticed this issue when coupling a neo4j error with boom.internal from the boom package resulting in a bad error message (code found here).

@lutovich
Copy link
Contributor

@legraphista thanks for this PR! I think it is a good change. We'll also change errors to always be Neo4jError and not contain Structure thingy. See #201.

@lutovich lutovich merged commit ade8c29 into neo4j:1.0 Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants