Improve failure handling for RESET and ACK_FAILURE #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed RESET that does not mute ACK_FAILURE handling.
Both RESET and ACK_FAILURE messages will now be immediately flushed to the network to make sure connections are fully cleaned up before being returned to the pool. Outbound messages will only be sent if the connection is not broken. Failure to RESET or ACK_FAILURE will be considered a fatal error, unless ACK_FAILURE was ignored because of a subsequent RESET.
adam-cowley
pushed a commit
to adam-cowley/neo4j-javascript-driver
that referenced
this pull request
Jun 12, 2018
…failures Improve failure handling for RESET and ACK_FAILURE Added native Date style getter functions for temporal data types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
RESETthat does not muteACK_FAILUREhandling.Both
RESETandACK_FAILUREmessages will now be immediately flushed to the network to make sure connections are fully cleaned up before being returned to the pool. Outbound messages will only be sent if the connection is not broken. Failure toRESETorACK_FAILUREwill be considered a fatal error, unlessACK_FAILUREwas ignored because of a subsequentRESET.Backport of #376