Fix some broken imports #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes: SyntaxError: The requested module './request-message.js' does not provide an export named 'ALL'
bradenmacdonald
commented
Dec 23, 2021
bradenmacdonald
commented
Dec 23, 2021
bradenmacdonald
commented
Dec 23, 2021
bradenmacdonald
commented
Dec 23, 2021
bigmontz
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was working on a Deno driver for Neo4j that uses this codebase, I found that Deno was detecting some invalid imports in the code.
In particular, a few places in the code try to import a constant called
ALLfrombolt/request-message.js, but that constant was renamed a year ago toFETCH_ALL.I'm not sure why the existing tooling didn't catch this import error or why Node/TypeScript didn't complain about it.
For the other changes, I'll add an inline comment in this PR to explain them.