-
Notifications
You must be signed in to change notification settings - Fork 149
Enabling BoltProtocol v5 and the new elementId in the graph types #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
055c130
to
276469f
Compare
The format of the identifiers used by the kernel is changing from the current long that represents a file offset to a more flexible format needed by the new Freki storage engine. In 5.0 the new storage engine will be ‘off’ by default, at some point in the future it will be enabled by default. The drivers will need to be able to support the old format alongside the new one in 5.0. To do this the existing long will remain and a new parallel identifier will be added that is of type string. The new string version will contain the long value for servers using the older non Freki storage engine e.g. versions < 5.0 and versions 5.x with Freki disabled. The following changes in the graph types was done for accomodating the elementId: - in `Node`: - Add `elementId: string` for identifying the element; - Deprecate `identity: NumberOrInteger` - in `Relationship`: - Add `elementId: string` for identifiying the element; - Deprecate `identity: NumberOrInteger` - Add `startNodeElementId: string` for identifiying the start node; - Deprecate `start: NumberOrInteger` - Add `endNodeElementId: string` for identifiying the end node; - Deprecate `end: NumberOrInteger` - in `UnboundRelationship`: - Add `elementId: string` for identifying the element; - Deprecate `identity: NumberOrInteger`
276469f
to
b29d94c
Compare
thelonelyvulpes
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format of the identifiers used by the kernel is changing from the current long that represents a file offset to a more flexible format needed by the new Freki storage engine. In 5.0 the new storage engine will be ‘off’ by default, at some point in the future it will be enabled by default. The drivers will need to be able to support the old format alongside the new one in 5.0. To do this the existing long will remain and a new parallel identifier will be added that is of type string.
The new string version will contain the long value for servers using the older non Freki storage engine e.g. versions < 5.0 and versions 5.x with Freki disabled.
The following changes in the graph types was done for accommodating the elementId:
Node
:elementId: string
for identifying the element;identity: NumberOrInteger
Relationship
:elementId: string
for identifying the element;identity: NumberOrInteger
startNodeElementId: string
for identifying the start node;start: NumberOrInteger
endNodeElementId: string
for identifying the end node;end: NumberOrInteger
UnboundRelationship
:elementId: string
for identifying the element;identity: NumberOrInteger