Skip to content

Fixing type definition in TransactionPromise #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core/src/transaction-promise.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@
* limitations under the License.
*/

import Transaction from "./transaction"
import Transaction from './transaction'
import {
ConnectionHolder
} from './internal/connection-holder'

import { Bookmarks } from './internal/bookmarks'
import { TxConfig } from "./internal/tx-config";
import { TxConfig } from './internal/tx-config'

/**
* Represents a {@link Promise<Transaction>} object and a {@link Transaction} object.
Expand All @@ -41,7 +41,7 @@ class TransactionPromise extends Transaction implements Promise<Transaction>{
private _beginMetadata?: any;
private _beginPromise?: Promise<Transaction>;
private _reject?: (error: Error) => void;
private _resolve?: (value?: Transaction | PromiseLike<Transaction> | undefined) => void;
private _resolve?: (value: Transaction | PromiseLike<Transaction>) => void;

/**
* @constructor
Expand Down