-
Notifications
You must be signed in to change notification settings - Fork 149
Add acceptance test to neo4j-deno-driver
and implement deno specific channel
#900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling the support for the acceptance tests to the generated DenoJS driver is a step towards to release it as library.
fde79d3
to
0dff616
Compare
neo4j-deno-driver
and implement deno specific channel
robsdedude
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦕
bigmontz
commented
Oct 3, 2022
bigmontz
commented
Oct 3, 2022
bigmontz
commented
Oct 3, 2022
Co-authored-by: Robsdedude <[email protected]>
Co-authored-by: Robsdedude <[email protected]>
1f30310
to
d9c32e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling the support for the acceptance tests to the generated DenoJS driver is a step towards to release it as library.
During the acceptance tests run, the
browser-channel
presents some errors handling write request when the socket was already closed. Verifying the socket status does not prevent the error, since the sockets which appears as connected could also presents the error because of a non-updated status (or the status get changed while the message is being send). This error is no catchable and make the application get closed.DenoChannel
was introduced for fixing this issue. This implementation uses theDeno.Conn
andDeno.TlsConn
for socket communication which causes a few drawbacks such as:TRUST_ALL_CERTIFICATES
should be handle by--unsafely-ignore-certificate-errors
and not by driver configuration. See, https://deno.com/blog/v1.13#disable-tls-verification;Deno.TlsConn
fails hard in certificate error which causes the application closes;Testkit Backend
The Deno Testkit Backend implementation re-uses most of the NodeJS implementation. Adjustments in the file import and the removal of a direct
neo4j
dependency1 in the common code was need for making it possible.Socket connection with testkit, backend controller and new entry-point were re-implemented for Deno backend. This implementation is located at
/packages/testkit-backend/deno
and documented at/packages/testkit-backend/deno/README.md
1 Other NodeJs/NPM dependencies like
tls
were also moved for Node specific files.