Skip to content

Add acceptance test to neo4j-deno-driver and implement deno specific channel #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Oct 5, 2022

Conversation

bigmontz
Copy link
Contributor

@bigmontz bigmontz commented Mar 14, 2022

Enabling the support for the acceptance tests to the generated DenoJS driver is a step towards to release it as library.

During the acceptance tests run, the browser-channel presents some errors handling write request when the socket was already closed. Verifying the socket status does not prevent the error, since the sockets which appears as connected could also presents the error because of a non-updated status (or the status get changed while the message is being send). This error is no catchable and make the application get closed.

DenoChannel was introduced for fixing this issue. This implementation uses the Deno.Conn and Deno.TlsConn for socket communication which causes a few drawbacks such as:

Testkit Backend

The Deno Testkit Backend implementation re-uses most of the NodeJS implementation. Adjustments in the file import and the removal of a direct neo4j dependency1 in the common code was need for making it possible.

Socket connection with testkit, backend controller and new entry-point were re-implemented for Deno backend. This implementation is located at /packages/testkit-backend/deno and documented at /packages/testkit-backend/deno/README.md

1 Other NodeJs/NPM dependencies like tls were also moved for Node specific files.

Enabling the support for the acceptance tests to the generated DenoJS driver is a step
towards to release it as library.
@bigmontz bigmontz changed the title Add Testkit support to DenoJS Add acceptance test to neo4j-deno-driver and implement deno specific channel Sep 27, 2022
@bigmontz bigmontz marked this pull request as ready for review September 29, 2022 12:10
@robsdedude robsdedude self-requested a review October 3, 2022 11:37
Copy link
Member

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦕

@bigmontz bigmontz merged commit 1418f42 into neo4j:5.0 Oct 5, 2022
@bigmontz bigmontz deleted the 5.0-deno-js-tests branch October 5, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants