Avoid sending resets when it is not needed #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmontz
changed the title
bigmontz
force-pushed
the
5.0-minimal-resets
branch
from
4d8d5f0 to
9a540a3
Compare
bigmontz
force-pushed
the
5.0-minimal-resets
branch
2 times, most recently
from
26529bc to
dfd7af1
Compare
bigmontz
force-pushed
the
5.0-minimal-resets
branch
from
dfd7af1 to
302ff74
Compare
bigmontz
force-pushed
the
5.0-minimal-resets
branch
from
db7eae8 to
3fdf49f
Compare
The `RESET` should be send when a failure occurs or whenever the connection is being sent back to the pool with a pending request running, i.e. the bolt server is not in the `READY` state. These changes also affect the `verifyConnectivity` and `getServerInfo` implementation. The `RESET` message is not sent in these methods if it is a newly created connection.
bigmontz
force-pushed
the
5.0-minimal-resets
branch
from
a12eaeb to
6398a1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RESETshould be send when a failure occurs or whenever the connection is being sent backto the pool with a pending request running, i.e. the bolt server is not in the
READYstate.These changes also affect the
verifyConnectivityandgetServerInfoimplementation.The
RESETmessage is not sent in these methods if it is a newly created connection.