Deprecate Session.(read|write)Transaction in favor of execute(Read|Write) methods
#911
Conversation
…d|Write)" methods The new methods provides a `ManagedTransaction` objects to the transaction functions. These transaction objects don't have `commit`, `rollback` and `close` capabilities exposed in the API.
bigmontz
changed the title
Session.(read|write)Transaction in favor for execute(Read|Write) methodsSession.(read|write)Transaction in favor of execute(Read|Write) methods
| * @returns {Observable} | ||
| */ | ||
| _executeInTransaction (accessMode, work, transactionConfig) { | ||
| const wrapper = txc => new RxManagedTransaction({ |
There was a problem hiding this comment.
wouldn't it be easier if RxManagedTransaction constructor accepted txc as its argument instead of an arbitrary object?
There was a problem hiding this comment.
The bind will only change places at the end. I don't want to keep reference from the transaction inside the ManagedTransaction to avoid the client code by pass the encapsulation and commit/rollback/close it anyway.
There was a problem hiding this comment.
what about:
class RxManagedTransaction {
constructor(txc) {
this._run = txc.run.bind(txc)
this._isOpen = tcx.isOpen.bind(txc)
}so you don't have to repeat the destructuring every time you call the constructor
There was a problem hiding this comment.
I've moved to the binding to a static factory method called fromTransaction. It makes easier to pass the function as parameter.
Co-authored-by: Florent Biville <[email protected]>
| * @returns {Observable} | ||
| */ | ||
| _executeInTransaction (accessMode, work, transactionConfig) { | ||
| const wrapper = txc => new RxManagedTransaction({ |
There was a problem hiding this comment.
what about:
class RxManagedTransaction {
constructor(txc) {
this._run = txc.run.bind(txc)
this._isOpen = tcx.isOpen.bind(txc)
}so you don't have to repeat the destructuring every time you call the constructor
packages/neo4j-driver/test/internal/transaction-executor.test.js
Outdated
Show resolved
Hide resolved
The new methods provides a
ManagedTransactionobjects to the transaction functions. Thesetransaction objects don't have
commit,rollbackandclosecapabilities exposed in the API.