Skip to content

Implementing new structures for DateTime in Bolt 5.0 #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 29, 2022

Conversation

bigmontz
Copy link
Contributor

The structures with signature 0x46 and 0x66 are being replaced by 0x49 and 0x69. This new structures changes the meaning of seconds and nano seconds from adjusted Unix epoch to UTC.

This changes have with goal of avoiding unexistent or ambiguos ZonedDateTime to be received or sent over Bolt.

Bolt v4.3 and v4.4 were patched to support this feature if the server supports the patch.

@bigmontz bigmontz force-pushed the 5.0-datetime-utc branch 4 times, most recently from 84c7df7 to 566dde8 Compare June 22, 2022 15:36
bigmontz added a commit to bigmontz/neo4j-javascript-driver that referenced this pull request Jun 23, 2022
The structures with signature `0x46` and `0x66` are being replaced by `0x49` and `0x69`. This new structures changes the meaning of seconds and nano seconds from `adjusted Unix epoch`  to `UTC`.

This changes have with goal of avoiding unexistent or ambiguos ZonedDateTime to be received or sent over Bolt.

Bolt v4.3 and v4.4 were patched to support this feature if the server supports the patch.

This is a backport of neo4j#948
@bigmontz bigmontz force-pushed the 5.0-datetime-utc branch 2 times, most recently from 8c3d498 to fb22358 Compare June 28, 2022 08:57
@bigmontz bigmontz merged commit c6164d7 into neo4j:5.0 Jun 29, 2022
@bigmontz bigmontz deleted the 5.0-datetime-utc branch June 29, 2022 10:36
bigmontz added a commit that referenced this pull request Jun 29, 2022
The structures with signature `0x46` and `0x66` are being replaced by `0x49` and `0x69`. This new structures changes the meaning of seconds and nano seconds from `adjusted Unix epoch`  to `UTC`.

This changes have with goal of avoiding un-existing or ambiguous ZonedDateTime to be received or sent over Bolt.

Bolt v4.3 and v4.4 were patched to support this feature if the server supports the patch.

This is a back-port of #948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant